Rename bot family, curate analyze plots, tier evaluation cadence
Three coordinated hygiene changes; none target the diagnosed
selection-bias bottleneck. They make the codebase honestly reflect the
pure-self-play stance and reduce dashboard noise.
Bot rename (drop the unhelpful safe_ prefix; suffixes describe behaviour):
- safe_heuristic_loose -> heuristic_aggressive
- safe_heuristic -> heuristic_balanced
- safe_heuristic_strict -> heuristic_cautious
- noisy_safe -> heuristic_noisy
- passive_discard -> discard_only
Class renames in bots/: SafeHeuristicBot -> HeuristicBot,
SafeHeuristicParams -> HeuristicParams, PassiveDiscardBot -> DiscardOnlyBot,
plus loose/strict parameter constants. Backwards compatibility was dropped
intentionally per user instruction; no aliases. Active configs, docs,
scripts, tests updated. Archive directories (configs/archive,
docs/archive, runs/archive) left intact and may still reference old
names per their read-only policy. The src/.../bots/passive.py module was
renamed to discard_only.py via git mv.
Analyze plot curation (deep_cfr/analyze.py):
- Added analysis_00_core.png as the canonical daily dashboard with 10
heuristic-free metrics (loss/{advantage,strategy}; vs heuristic_cautious:
avg_score_diff0, win_rate0, avg_opened_colors, positive_expedition_rate,
bonus_expedition_rate, score_per_opened_color, policy_entropy; vs random:
win_rate0).
- Removed analysis_05_open_quality.png (bad/weak/good open rates,
recoverable score) and analysis_07_calibration.png (calibration gap,
recoverable mean) - both relied on the heuristic recoverable_score
classifier already dropped from inputs.
- Removed SELECTIVITY_PLOTS and plot_selectivity (heuristic-laden).
- SUMMARY_EVAL_METRICS no longer includes bad_open_rate or
calibration_gap.
- PlotSpec gained an opponents allowlist so the new core section can pin
a specific opponent per panel without restructuring plot_section.
Tiered evaluation cadence (EvaluationConfig):
- Added extended_opponents and extended_eval_every (default 0 = disabled).
- opponents_for_iteration(iteration) returns the core list every
eval_every and appends extended_opponents (de-duplicated) when
iteration is also a multiple of extended_eval_every.
- default.yaml now uses 3 core opponents (random, discard_only,
heuristic_cautious) every 5 iterations and 3 extended opponents
(heuristic_balanced, heuristic_aggressive, heuristic_noisy) every 50
iterations. random is the floor sanity. discard_only is the
zero-pit detector / absolute-score reference (its score is always 0,
so eval/discard_only/avg_score_diff0 directly equals the model's raw
average score). heuristic_cautious is the ceiling and the
archive-comparable benchmark used in the prior diagnostic sections.
Net eval cost reduction: roughly 50% (3 opponents x every 5 iter, plus
6 opponents x every 50 iter, vs the prior 6 x every 5).
Documented in docs/plans/deep-cfr-selectivity.md section 9.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -157,9 +157,9 @@ Python-object touch가 깔려 있다 (per-node, per-iteration):
|
||||
`self.strategy_samples.append(...)` (file:903, 937, 969). list의
|
||||
PyObject reference 갱신은 free-threaded Python에서도 atomic refcount
|
||||
비용을 추가로 부담한다.
|
||||
6. **`SafeHeuristicBot.act(state)`** — `_fixed_opponent_action`
|
||||
6. **`HeuristicBot.act(state)`** — `_fixed_opponent_action`
|
||||
(file:633, 652), `_rollout_value` (file:841). Python class
|
||||
메서드 호출. `safe_heuristic` 옵션 사용 시만 핫.
|
||||
메서드 호출. `heuristic_balanced` 옵션 사용 시만 핫.
|
||||
7. **`league_advantage_networks` indexing** — `_self_play_snapshot_
|
||||
networks` (file:802), `[-recent_count:]`, `[:max(0, ...)]` slicing
|
||||
= Python list slicing.
|
||||
@@ -267,15 +267,15 @@ candidates = self.league_advantage_networks[:max(0, len(self.league_advantage_ne
|
||||
- 빈도: traversal 진입 시 한 번 (`traverse`에서 미리 픽), 재귀 안에서는
|
||||
`active_self_play_networks`만 본다. 따라서 cold path. 변환 불필요.
|
||||
|
||||
### B6. `SafeHeuristicBot.act(state)` — Python bot
|
||||
### B6. `HeuristicBot.act(state)` — Python bot
|
||||
|
||||
```python
|
||||
# traversal.pyx:633, 652, 841
|
||||
return int(self.safe_heuristic_opponent_bot.act(state))
|
||||
return int(self.heuristic_opponent_bot.act(state))
|
||||
```
|
||||
|
||||
- 빈도: `opponent_policy=safe_heuristic` 또는 `cutoff_rollout_policy=
|
||||
safe_heuristic`일 때만. 현 default는 self_play_league + score_diff
|
||||
- 빈도: `opponent_policy=heuristic_balanced` 또는 `cutoff_rollout_policy=
|
||||
heuristic_balanced`일 때만. 현 default는 self_play_league + score_diff
|
||||
cutoff (per memory의 opponent_policy_network_divergence note + AGENTS).
|
||||
- 변환 난이도: **Medium-High** (Python class 전체를 cython화). 현 default
|
||||
config에서는 핫 아님 — 시도하지 않는 게 합리.
|
||||
|
||||
Reference in New Issue
Block a user