diff --git a/configs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability.yaml b/configs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability.yaml similarity index 90% rename from configs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability.yaml rename to configs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability.yaml index 7b39795..453a933 100644 --- a/configs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability.yaml +++ b/configs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability.yaml @@ -1,5 +1,5 @@ run: - experiment_name: lost_cities_deep_cfr_pure_self_play_zero_pit_poc_full_depth_slot_aware_playability + experiment_name: lost_cities_deep_cfr_selfplay_full_depth_slot_playability seed: 79 max_iterations: null max_hours: 4 @@ -82,7 +82,7 @@ evaluation: - noisy_safe checkpoint: - directory: runs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability + directory: runs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability save_every_iteration: false save_iteration_interval: 10 save_latest_only: false diff --git a/docs/deep-cfr-legacy-experiment-reproduction.md b/docs/deep-cfr-legacy-experiment-reproduction.md index 559480b..209203c 100644 --- a/docs/deep-cfr-legacy-experiment-reproduction.md +++ b/docs/deep-cfr-legacy-experiment-reproduction.md @@ -13,6 +13,10 @@ Exact legacy YAML compatibility is not required. It is acceptable to create a new config file under this repository as long as every relevant legacy hyperparameter is represented explicitly and the differences are documented. +Mapped config in this repository: + +`configs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability.yaml` + ## Source Experiment Legacy config path: diff --git a/tests/games/classic/test_deep_cfr_trainer.py b/tests/games/classic/test_deep_cfr_trainer.py index 91b7aee..9c0c610 100644 --- a/tests/games/classic/test_deep_cfr_trainer.py +++ b/tests/games/classic/test_deep_cfr_trainer.py @@ -32,11 +32,9 @@ def test_deep_cfr_loads_smoke_yaml_config() -> None: def test_deep_cfr_loads_mapped_legacy_reproduction_config() -> None: - config = load_config( - "configs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability.yaml" - ) + config = load_config("configs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability.yaml") - assert config.run.experiment_name.endswith("slot_aware_playability") + assert config.run.experiment_name.endswith("slot_playability") assert config.run.seed == 79 assert config.run.max_iterations is None assert config.run.max_hours == 4 @@ -57,8 +55,7 @@ def test_deep_cfr_loads_mapped_legacy_reproduction_config() -> None: assert config.evaluation.on_max_steps == "score_diff" assert config.checkpoint.save_iteration_interval == 10 assert ( - config.checkpoint.directory - == "runs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability" + config.checkpoint.directory == "runs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability" ) @@ -79,9 +76,7 @@ def test_deep_cfr_train_cli_count_overrides_disable_duration_limits() -> None: "no_save": True, }, )() - config = load_config( - "configs/deep_cfr/pure_self_play_zero_pit_poc_full_depth_slot_aware_playability.yaml" - ) + config = load_config("configs/deep_cfr/deep_cfr_selfplay_full_depth_slot_playability.yaml") overridden = _with_overrides(config, _train_overrides_from_args(args))